Fixes #9540: Create the expected reports file for ncf in system techniques instead of first log #1072
Conversation
| # because the fist call to the logger may be in audit mode. | ||
| "create ncf expected reports" usebundle => _create_current_expected_reports_file; | ||
| # Aggregate the results of the two actions | ||
| "combine result classes" usebundle => _classes_combine_two("ncf_init", "logger_rudder_final_resfile", "rudder_ncf_initialization") |
There was a problem hiding this comment.
Not sure if we should create another component or aggregate the data.
These components are not really understandable, but it is questionable to lose reporting granularity on agent side.
There was a problem hiding this comment.
ha, this is a good question - i think both are ncf initialization, so we can surely combine them
| "report about ncf init" usebundle => rudder_common_reports_generic("Common", "ncf_init", "&TRACKINGKEY&", "ncf Initialization", "None", "The ncf initialization"); | ||
| "initialize ncf" usebundle => initialization; | ||
| # Force generating expected reports file for Rudder logger | ||
| # because the fist call to the logger may be in audit mode. |
| # because the fist call to the logger may be in audit mode. | ||
| "create ncf expected reports" usebundle => _create_current_expected_reports_file; | ||
| # Aggregate the results of the two actions | ||
| "combine result classes" usebundle => _classes_combine_two("ncf_init", "logger_rudder_final_resfile", "rudder_ncf_initialization") |
There was a problem hiding this comment.
ha, this is a good question - i think both are ncf initialization, so we can surely combine them
| "create ncf expected reports" usebundle => _create_current_expected_reports_file; | ||
| # Aggregate the results of the two actions | ||
| "combine result classes" usebundle => _classes_combine_two("ncf_init", "logger_rudder_final_resfile", "rudder_ncf_initialization") | ||
| "report about ncf init" usebundle => rudder_common_reports_generic("Common", "rudder_ncf_initialization", "&TRACKINGKEY&", "ncf Initialization", "None", "The ncf initialization"); | ||
|
|
||
| } |
There was a problem hiding this comment.
aren't you missing a change in log_rudder.cf to not call _create_current_expected_reports_file ?
There was a problem hiding this comment.
It is only called when needed and this PR is against 4.0, and we need to keep compatibility of ncf master with 3.2.
…iques instead of first log
|
Commit modified |
amousset
force-pushed
the
bug_9540/create_the_expected_reports_file_for_ncf_in_system_techniques_instead_of_first_log
branch
from
5a4830e
to
f0fd18e
Compare
|
OK, merging this PR |
https://www.rudder-project.org/redmine/issues/9540