Fix #9794: Malformed .gz inventory breaks upload process #1093
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peckpeck
reviewed
Dec 16, 2016
| if [ $UNZIP_COMMAND_RET -ne 0 ] | ||
| then | ||
| echo "ERROR: failed to decompress inventory in ${FILENAME} az gzip, putting it in the failed directory" | ||
| mv "${FILENAME}" "${FAILEDDIR}/`basename ${FILENAME}`-$(date --rfc-3339=date)" |
There was a problem hiding this comment.
I coped that part from ~line 100 to that if-statement, to have the coding style as it was originally, and not to mix with my style. The question is, do you guys mix $() and `` :-)
| then | ||
| echo "ERROR: failed to decompress inventory in ${FILENAME} az gzip, putting it in the failed directory" | ||
| mv "${FILENAME}" "${FAILEDDIR}/`basename ${FILENAME}`-$(date --rfc-3339=date)" | ||
| mv "${FILENAME_SIGN}" "${FAILEDDIR}/`basename ${FILENAME_SIGN}`-$(date --rfc-3339=date)" |
There was a problem hiding this comment.
There is not always a signature file, you should avoid errors here with a [ -f ] &&
There was a problem hiding this comment.
same as above. will rework that part of code without using your logic, but as I see well suited.
armeniaca
force-pushed
the
upstream/fix/9794_malformed_gz_breaks_upload
branch
from
555bf5e
to
c8f46b4
Compare
|
Sorry for the original mixed style and thank you for the PR. |
|
OK, merging this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.