Fixes #10081: Use rudder agent run as cfruncommand #1111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ncharles
requested changes
Feb 6, 2017
| @@ -246,8 +246,9 @@ body server control | |||
| # last single quote in cfruncommand is left open, so that | |||
| # arguments (like -K and --remote-bundles) are properly appended. | |||
| cfruncommand => "${def.cf_runagent_shell} -c \' | |||
| ${sys.cf_agent} -I -D cfruncommand -f failsafe.cf \&\& | |||
| ${sys.cf_agent} -I -D cfruncommand"; | |||
| ${g.rudder_command} agent update && | |||
There was a problem hiding this comment.
and you will need an access rule for g.rudder_command, like
"$(g.rudder_command)" comment => "Grant access to rudder agent command for cfruncommand", admit => { ${def.policy_server} };
|
Commit modified |
amousset
force-pushed
the
ust_10081/use_rudder_agent_run_as_cfruncommand
branch
from
4e03fde
to
f39400f
Compare
|
Commit modified |
amousset
force-pushed
the
ust_10081/use_rudder_agent_run_as_cfruncommand
branch
from
f39400f
to
028429b
Compare
peckpeck
reviewed
Feb 8, 2017
| @@ -114,7 +114,7 @@ bundle server access_rules | |||
| admit => { host2ip("${server_info.cfserved}"), string_downcase(escape("${server_info.cfserved}")) }; | |||
|
|
|||
| !windows:: | |||
| "${def.cf_runagent_shell}" | |||
| "${g.rudder_command}" comment => "Grant access to rudder agent command for cfruncommand", | |||
There was a problem hiding this comment.
So we won't need the shll anywhere ?
|
I think it was because if download fails, promises are probably not up to date. |
|
Commit modified |
amousset
force-pushed
the
ust_10081/use_rudder_agent_run_as_cfruncommand
branch
from
028429b
to
6dc112d
Compare
|
ping @peckpeck |
|
Commit modified |
amousset
force-pushed
the
ust_10081/use_rudder_agent_run_as_cfruncommand
branch
from
6dc112d
to
b455281
Compare
|
OK, merging this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://www.rudder-project.org/redmine/issues/10081