Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #7622: Technique files contains UTF-8 chars (especially spaces) #1139

Conversation

jooooooon
Copy link
Member

Copy link
Member Author

@jooooooon jooooooon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The huge majority of this PR is replaces non-breakable spaces by plain spaces.

The other part that requires a more detailed review is a new test to detect these non-breakable spaces, in check-techniques.sh. I've added a comment to this file in the PR to make it easier to find.

@@ -0,0 +1 @@
scripts/technique-files
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file is now downloaded by Makefile from a different repo, so shouldn't be tracked here

echo "---------------------------------------------------------------------"
exit 1
fi
done || EXIT=1
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the new test that detects unbreakable space chars

@Normation-Quality-Assistant
Copy link
Contributor

This PR is not mergeable to upper versions.
Since it is "Ready for merge" you must merge it by yourself using the following command:
rudder-dev merge https://github.com/Normation/rudder-techniques/pull/1139
-- Your faithful QA

@jooooooon
Copy link
Member Author

OK, merging this PR

@jooooooon jooooooon merged commit 5f5cd23 into Normation:branches/rudder/3.1 Apr 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants