Fixes #10962: Add ssl based authentication to policies #1157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amousset
reviewed
Jun 21, 2017
| @@ -0,0 +1,82 @@ | |||
| ##################################################################################### | |||
| # Copyright 2014 Normation SAS | |||
amousset
reviewed
Jun 21, 2017
| @@ -42,7 +53,6 @@ along with this program. If not, see <http://www.gnu.org/licenses/>. | |||
| <INCLUDED>false</INCLUDED> | |||
| </TML> | |||
| <TML name="nodeslist.json"> | |||
| <OUTPATH>distributePolicy/1.0/nodeslist.json</OUTPATH> | |||
amousset
reviewed
Jun 21, 2017
|
|
||
| rudder_apache_acl_repaired:: | ||
|
|
||
| "${paths.path[service]}" |
There was a problem hiding this comment.
Why not service_reload("${apache_service}")?
|
Commit modified |
peckpeck
force-pushed
the
arch_10962/add_ssl_based_authentication_to_policies
branch
from
bf2be31
to
eea0c23
Compare
amousset
reviewed
Jun 21, 2017
|
|
||
| rudder_apache_acl_repaired:: | ||
| "any" usebundle => rudder_common_report("DistributePolicy", "log_info", "&TRACKINGKEY&", "Configure apache ACL", "None", "Apache has been reloaded successfully"), | ||
| ifvarclass => "${apache_service}_repaired" |
There was a problem hiding this comment.
service_reload_${apache_service}_repaired?
|
Commit modified |
peckpeck
force-pushed
the
arch_10962/add_ssl_based_authentication_to_policies
branch
from
eea0c23
to
6b02efc
Compare
amousset
reviewed
Jun 21, 2017
| "any" usebundle => rudder_common_report("DistributePolicy", "result_error", "&TRACKINGKEY&", "Configure apache ACL", "None", "Apache ACLs could not be edited"); | ||
|
|
||
| rudder_apache_acl_repaired:: | ||
| "any" usebundle => rudder_common_report("DistributePolicy", "log_info", "&TRACKINGKEY&", "Configure apache ACL", "None", "Apache has been reloaded successfully"), |
|
Commit modified |
peckpeck
force-pushed
the
arch_10962/add_ssl_based_authentication_to_policies
branch
from
6b02efc
to
69382e9
Compare
|
OK, merging this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://www.rudder-project.org/redmine/issues/10962