Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #11405: Add a new syntax for rudder parameters #1200

Merged
merged 1 commit into from Sep 26, 2017
Merged

Fixes #11405: Add a new syntax for rudder parameters #1200

merged 1 commit into from Sep 26, 2017

Conversation

amousset
Copy link
Member

@amousset amousset force-pushed the arch_11405/add_a_new_syntax_for_rudder_parameters branch from 85ad1f4 to d1fa122 Compare September 22, 2017 08:51
@amousset
Copy link
Member Author

Commit modified

1 similar comment
@amousset
Copy link
Member Author

Commit modified

@amousset amousset force-pushed the arch_11405/add_a_new_syntax_for_rudder_parameters branch from d1fa122 to 680301c Compare September 22, 2017 08:53
ncharles
ncharles requested changes Sep 26, 2017
View reviewed changes
Copy link
Member

@ncharles ncharles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the path of the readen file is invalid :(

techniques/system/common/1.0/rudder-parameters.st Outdated
{
vars:
# The files to read
"parameters_file" string => "${this.promise_dirname}/../rudder-parameters.json";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not use "${sys.workdir}/inputs" ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actually, this path is wrong, as it would search for the file in common/rudder-parameters.json

@amousset
Copy link
Member Author

Commit modified

@amousset amousset force-pushed the arch_11405/add_a_new_syntax_for_rudder_parameters branch from 680301c to 2a319a1 Compare September 26, 2017 10:04
@Normation-Quality-Assistant
Copy link
Contributor

OK, merging this PR

@Normation-Quality-Assistant Normation-Quality-Assistant merged commit 2a319a1 into Normation:branches/rudder/4.1 Sep 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ncharles ncharles ncharles requested changes

Assignees
No one assigned
Labels
Ready for merge
Projects
None yet
Milestone
No milestone
3 participants
@amousset @Normation-Quality-Assistant @ncharles