Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #10912: Duration of logrotate for /var/log/rudder/ is too long making /var/log too big #1216

Merged
merged 1 commit into from
Dec 5, 2017
Merged

Fixes #10912: Duration of logrotate for /var/log/rudder/ is too long making /var/log too big #1216

merged 1 commit into from
Dec 5, 2017

Conversation

peckpeck
Copy link
Member

@peckpeck peckpeck commented Nov 6, 2017

@Normation-Quality-Assistant
Copy link
Contributor

This PR breaks qa-test

-- stdout -- 
Your branch is behind 'NRM/branches/rudder/3.1' by 1 commit, and can be fast-forwarded.
  (use "git pull" to update your local branch)
Updating 8c5ef98..a2cfb8d
Fast-forward
[...]
 $ git clean -f
Running merge tests
 $ cd "/var/lib/quality-assistant/rudder-techniques" && ./qa-test --merge

-- stderr --
From github.com:peckpeck/rudder-techniques
 * [new branch]      bug_10912/duration_of_logrotate_for_var_log_rudder_is_too_long_making_var_log_too_big -> bug_10912/duration_of_logrotate_for_var_log_rudder_is_too_long_making_var_log_too_big_pr
Switched to branch 'branches/rudder/3.1'
Switched to a new branch '3.1_test'

You should run ./qa-test in your repository to make sure it works.
You can also run rudder-dev merge https://github.com/Normation/rudder-techniques/pull/1216 --test to test with upmerging.
After this, you can remove the Ready for merge tag
-- Your faithful QA

@peckpeck peckpeck force-pushed the bug_10912/duration_of_logrotate_for_var_log_rudder_is_too_long_making_var_log_too_big branch from 8f2b863 to 6ba1df9 Compare November 29, 2017 13:07
@peckpeck
Copy link
Member Author

Commit modified

@Normation-Quality-Assistant
Copy link
Contributor

This PR is not mergeable to upper versions.
Since it is "Ready for merge" you must merge it by yourself using the following command:
rudder-dev merge https://github.com/Normation/rudder-techniques/pull/1216
-- Your faithful QA

@Normation-Quality-Assistant
Copy link
Contributor

This PR breaks qa-test

-- stdout -- 
Your branch is up-to-date with 'NRM/branches/rudder/3.1'.
Already up-to-date.
Deleted branch 3.1_test (was 340d30e).
Merge made by the 'recursive' strategy.
[...]
bash: line 0: echo: write error: Broken pipe
bash: line 0: echo: write error: Broken pipe
bash: line 0: echo: write error: Broken pipe
bash: line 0: echo: write error: Broken pipe
bash: line 0: echo: write error: Broken pipe
bash: line 0: echo: write error: Broken pipe
bash: line 0: echo: write error: Broken pipe
bash: line 0: echo: write error: Broken pipe
bash: line 0: echo: write error: Broken pipe

You should run ./qa-test in your repository to make sure it works.
You can also run rudder-dev merge https://github.com/Normation/rudder-techniques/pull/1216 --test to test with upmerging.
After this, you can remove the Ready for merge tag
-- Your faithful QA

@Normation-Quality-Assistant
Copy link
Contributor

This PR is not mergeable to upper versions.
Since it is "Ready for merge" you must merge it by yourself using the following command:
rudder-dev merge https://github.com/Normation/rudder-techniques/pull/1216
-- Your faithful QA

@Normation-Quality-Assistant
Copy link
Contributor

This PR is not mergeable to upper versions.
Since it is "Ready for merge" you must merge it by yourself using the following command:
rudder-dev merge https://github.com/Normation/rudder-techniques/pull/1216
-- Your faithful QA

5 similar comments
@Normation-Quality-Assistant
Copy link
Contributor

This PR is not mergeable to upper versions.
Since it is "Ready for merge" you must merge it by yourself using the following command:
rudder-dev merge https://github.com/Normation/rudder-techniques/pull/1216
-- Your faithful QA

@Normation-Quality-Assistant
Copy link
Contributor

This PR is not mergeable to upper versions.
Since it is "Ready for merge" you must merge it by yourself using the following command:
rudder-dev merge https://github.com/Normation/rudder-techniques/pull/1216
-- Your faithful QA

@Normation-Quality-Assistant
Copy link
Contributor

This PR is not mergeable to upper versions.
Since it is "Ready for merge" you must merge it by yourself using the following command:
rudder-dev merge https://github.com/Normation/rudder-techniques/pull/1216
-- Your faithful QA

@Normation-Quality-Assistant
Copy link
Contributor

This PR is not mergeable to upper versions.
Since it is "Ready for merge" you must merge it by yourself using the following command:
rudder-dev merge https://github.com/Normation/rudder-techniques/pull/1216
-- Your faithful QA

@Normation-Quality-Assistant
Copy link
Contributor

This PR is not mergeable to upper versions.
Since it is "Ready for merge" you must merge it by yourself using the following command:
rudder-dev merge https://github.com/Normation/rudder-techniques/pull/1216
-- Your faithful QA

@peckpeck
Copy link
Member Author

peckpeck commented Dec 5, 2017

OK, merging this PR

@peckpeck peckpeck merged commit 6ba1df9 into Normation:branches/rudder/3.1 Dec 5, 2017
@peckpeck peckpeck deleted the bug_10912/duration_of_logrotate_for_var_log_rudder_is_too_long_making_var_log_too_big branch July 13, 2020 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ncharles ncharles ncharles approved these changes

Assignees
No one assigned
Labels
qa: Can't merge
Projects
None yet
Milestone
No milestone
3 participants
@peckpeck @Normation-Quality-Assistant @ncharles