Fixes #11844: Port some more techniques to multi-versionned format #1226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Commit modified |
1 similar comment
|
Commit modified |
ncharles
force-pushed
the
ust_11844/port_some_more_techniques_to_multi_versionned_format
branch
from
d05b7d5
to
9f20772
Compare
|
Don't merge for now |
|
Commit modified |
ncharles
force-pushed
the
ust_11844/port_some_more_techniques_to_multi_versionned_format
branch
from
9f20772
to
bffce41
Compare
amousset
reviewed
Dec 14, 2017
| <BUNDLES> | ||
| <NAME>download_from_shared_folder</NAME> | ||
| </BUNDLES> | ||
| <AGENT type="dsc"> |
There was a problem hiding this comment.
Isn't this a bug that should be fixed in previous version of the technique?
There was a problem hiding this comment.
There was a problem hiding this comment.
i'll do it in a separe issue, if it's ok with you
|
OK, merging this PR |
ncharles
commented
Dec 14, 2017
| </TMLS> | ||
| </AGENT> | ||
|
|
||
| <TMLS> |
There was a problem hiding this comment.
damn, there shouldn't be this TMLs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://www.rudder-project.org/redmine/issues/11844