Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #12124: Add post-hook to the manage key-value file techniques #1255

Conversation

peckpeck
Copy link
Member

@Normation-Quality-Assistant
Copy link
Contributor

This PR breaks qa-test

-- stdout -- 
Your branch is up-to-date with 'NRM/branches/rudder/4.1'.
Already up-to-date.
Deleted branch 4.1_test (was 8b44d74).
Merge made by the 'recursive' strategy.
[...]
Running merge tests
 $ cd "/var/lib/quality-assistant/rudder-techniques" && ./qa-test --merge

-- stderr --
From github.com:peckpeck/rudder-techniques
 * [new branch]      ust_12124/add_post_hook_to_the_manage_key_value_file_techniques -> ust_12124/add_post_hook_to_the_manage_key_value_file_techniques_pr
Switched to branch 'branches/rudder/4.1'
Switched to a new branch '4.1_test'
make: *** [test] Error 1

You should run ./qa-test in your repository to make sure it works.
You can also run rudder-dev merge https://github.com/Normation/rudder-techniques/pull/1255 --test to test with upmerging.
After this, you can remove the Ready for merge tag
-- Your faithful QA

@peckpeck peckpeck force-pushed the ust_12124/add_post_hook_to_the_manage_key_value_file_techniques branch from 3627d03 to 80b785c Compare February 15, 2018 16:01
@peckpeck
Copy link
Member Author

Commit modified

@Normation-Quality-Assistant
Copy link
Contributor

This PR is not mergeable to upper versions.
Since it is "Ready for merge" you must merge it by yourself using the following command:
rudder-dev merge https://github.com/Normation/rudder-techniques/pull/1255
-- Your faithful QA

@peckpeck
Copy link
Member Author

OK, merging this PR

@peckpeck peckpeck merged commit 80b785c into Normation:branches/rudder/4.1 Feb 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants