Fixes #11631: Implement disable-flag for policy server policy copy for nodes #1256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Don't merge for now |
ncharles
force-pushed
the
ust_11631/implement_disable_flag_for_policy_server_policy_copy_for_nodes
branch
from
ea6b170
to
e152eb4
Compare
|
Commit modified |
ncharles
force-pushed
the
ust_11631/implement_disable_flag_for_policy_server_policy_copy_for_nodes
branch
from
e152eb4
to
a98b965
Compare
amousset
reviewed
Feb 20, 2018
| # root server have only tools and nodelist to be updated | ||
| # relays have tools, ncf, masterfiles nodelist and shared_files folder to be updated. | ||
| pass3.root_server.propagate_tools_ok.nodeslist_copied.!(propagate_tools_error|could_not_copy_nodeslist):: | ||
| "any" usebundle => rudder_common_report("DistributePolicy", "result_success", "&TRACKINGKEY&", "Synchronize resources", "None", "All resources have been updated"); |
There was a problem hiding this comment.
Because on root_server we don't synchronize them (they are local), but we rather move them around or define hash of their values
amousset
approved these changes
Feb 20, 2018
|
OK, merging this PR |
|
Commit modified |
ncharles
force-pushed
the
ust_11631/implement_disable_flag_for_policy_server_policy_copy_for_nodes
branch
from
a98b965
to
db1ad67
Compare
amousset
approved these changes
Feb 20, 2018
|
OK, merging this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://www.rudder-project.org/redmine/issues/11631