Fixes #12297: Missing report for component "Post-modification hook" when cleaning files #1270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Commit modified |
Fdall
force-pushed
the
bug_12297/missing_report_for_component_post_modification_hook_when_cleaning_files
branch
from
2893b02
to
ecc27a4
Compare
… when cleaning files
|
Commit modified |
Fdall
force-pushed
the
bug_12297/missing_report_for_component_post_modification_hook_when_cleaning_files
branch
from
ecc27a4
to
3f93dcf
Compare
peckpeck
approved these changes
Mar 30, 2018
|
OK, merging this PR |
ncharles
reviewed
Nov 8, 2018
| "pass3" expression => "pass2"; | ||
| "pass2" expression => "pass1"; | ||
| "pass1" expression => "any"; | ||
|
|
||
| files: | ||
| iteration_2:: |
There was a problem hiding this comment.
i'm pretty sure it will break the permissions, that are set in the vars: iteration_1
There was a problem hiding this comment.
actually, it works for unknown reasons ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://www.rudder-project.org/redmine/issues/12297