Fixes #3630, #3629: Updated the motdConfiguration to the most up to date... #135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Added a new commit to separate parameters from logic |
| # Here, we will define reports for elements which only have a local visibility (like the MOTD file presence detection). | ||
| !windows.rudder_motd_absent:: | ||
| "any" | ||
| usebundle => rudder_common_report("${service_name}", "log_repaired", "&TRACKINGKEY&", "MOTD Configuration", "None", "The ${service_name} file was absent, it will be created"); |
There was a problem hiding this comment.
we should not have StringTemplate variable in this file; the goal is really to have pure cfengine
|
Pr updated, moved TRACKINGKEY to the parameters array |
| bundle agent rudder_motd_configuration_reporting(class_prefix, service_name) | ||
| { | ||
| methods: | ||
| "any" usebundle => rudder_common_reports_generic("${service_name}", "${class_prefix}_file_edition", "${rudder_motd_trackingkey}", "MOTD Configuration", "None", "The ${service_name} file"); |
There was a problem hiding this comment.
where is ${rudder_motd_trackingkey} defined ?
added 3 commits
June 11, 2013 18:02
…ate Technique creation Best practices.
…ate Technique creation Best practices. (Separated parameters from logic)
…ate Technique creation Best practices. (Removed TRACKINGVARIABLE entry from metadata.xml)
jooooooon
added a commit
that referenced
this pull request
Jun 11, 2013
…configuration_with_best_practices Fixes #3630, #3629: Updated the motdConfiguration to the most up to date...
amousset
pushed a commit
to amousset/rudder-techniques
that referenced
this pull request
Dec 8, 2015
…hich_prevent_to_relaunch_cfe Fixes #3996 - Fix typo into /opt/rudder/bin/check-rudder-agent which prevent from relaunching Rudder agent
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... Technique creation Best practices.
Ticket: http://www.rudder-project.org/redmine/issues/3630
To be merged in the 2.6 branch.