Fixes #4840: Job Scheduler Technique will miss some jobs when using a non-default agent execution frequency #1370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amousset
reviewed
Nov 16, 2018
| @@ -56,6 +56,29 @@ body classes rudder_common_classes_persist(prefix, persist) | |||
| persist_time => ${persist}; | |||
| } | |||
|
|
|||
|
|
|||
| body classes rudder_common_classes_exclusive_persist_codes(prefix, persist, keptcodes, repairedcodes, errorcodes) | |||
There was a problem hiding this comment.
Ideally, this should go into ncf lib.
There was a problem hiding this comment.
well, rudder-stdlib is full of deprectated stuff
There was a problem hiding this comment.
i wasn't sure about the ncf part - it's a rudder_ something, and that's not commont to have rudder_ stuff there
There was a problem hiding this comment.
You can rename it to remove rudder in the name, it is a generic body.
|
Commit modified |
ncharles
force-pushed
the
bug_4840/job_scheduler_technique_will_miss_some_jobs_when_using_a_non_default_agent_execution_frequency
branch
2 times, most recently
from
c81baf7
to
4407315
Compare
|
Commit modified |
amousset
reviewed
Dec 17, 2018
| pass2:: | ||
| # check if the job should run | ||
| "schedule_${iterator}" usebundle => | ||
| schedule_simple("${job_scheduler_canon_name[${iterator}]}_RudderUniqueID", "${g.agent_run_interval}", 0, "${max_execution_delay_hours_${iterator}}", "0", "${job_scheduler_time_min[${iterator}]}", "0", "0", "24", "0", "nodups"); |
There was a problem hiding this comment.
We should have a fallback on 5 mintues in case system techniques are not up to date.
ncharles
force-pushed
the
bug_4840/job_scheduler_technique_will_miss_some_jobs_when_using_a_non_default_agent_execution_frequency
branch
from
4407315
to
a9130b8
Compare
|
Commit modified |
… non-default agent execution frequency
ncharles
force-pushed
the
bug_4840/job_scheduler_technique_will_miss_some_jobs_when_using_a_non_default_agent_execution_frequency
branch
from
a9130b8
to
aa1ce5b
Compare
|
Commit modified |
|
to be merged with Normation/ncf#884 |
amousset
approved these changes
Dec 18, 2018
|
OK, merging this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.rudder.io/issues/4840