Fixes #13932: copyGitFile technique in very old version does not work anymore since a common variable has been removed #1376
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… anymore since a common variable has been removed
ncharles
approved these changes
Dec 3, 2018
|
OK, merging this PR |
peckpeck
reviewed
Dec 4, 2018
| @@ -108,6 +108,8 @@ bundle common server_info | |||
| "policy_server" string => ifelse(fileexists("${policy_server_file}"), | |||
| readfile("${policy_server_file}", 2048), | |||
| ""); | |||
| "cfserved" string => "${policy_server}"; | |||
There was a problem hiding this comment.
a comment on the reason of this variable and that it should be kept would have been welcome
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.rudder.io/issues/13932