Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #13975: Add compatibility sles classes in failsafe #1381

Merged
merged 1 commit into from
Jan 11, 2019
Merged

Fixes #13975: Add compatibility sles classes in failsafe #1381

merged 1 commit into from
Jan 11, 2019

Conversation

amousset
Copy link
Member

@ncharles
Copy link
Member

you hsould not change path of apache-vhost.tpl

peckpeck
peckpeck reviewed Dec 14, 2018
View reviewed changes
techniques/system/common/1.0/failsafe.st
@@ -126,6 +126,12 @@ bundle common g

# definition of the node roles
&NODEROLE&

classes:
# OS classes for compatibility
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't there be a scope => namespace ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope, it is a bundle common where classes are global by default.

@amousset
Copy link
Member Author

ping @peckpeck

@Normation-Quality-Assistant
Copy link
Contributor

OK, merging this PR

@Normation-Quality-Assistant Normation-Quality-Assistant merged commit 524daea into Normation:branches/rudder/4.3 Jan 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peckpeck peckpeck peckpeck approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@amousset @ncharles @Normation-Quality-Assistant @peckpeck