Fixes #13999: Cleanup reporting from rudder-techniques #1391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amousset
force-pushed
the
arch_13999/cleanup_reporting_from_rudder_techniques
branch
from
27b7981
to
8a764ab
Compare
|
Commit modified |
amousset
force-pushed
the
arch_13999/cleanup_reporting_from_rudder_techniques
branch
from
8a764ab
to
62c8334
Compare
|
Commit modified |
peckpeck
reviewed
Dec 18, 2018
| # Automatically defines classes bases on a given prefix | ||
| # The classes are defined based on the romises outcome | ||
| # | ||
| body classes rudder_common_classes(prefix) |
There was a problem hiding this comment.
Yes, this changes is parallel to Normation/ncf#887
peckpeck
reviewed
Dec 18, 2018
| # component_key : the value of the component reference variable (or None if undefined) | ||
| # message : An explanation message understandable by a human | ||
| # | ||
| bundle agent rudder_common_report(technique_name, status, identifier, component_name, component_key, message) |
peckpeck
approved these changes
Dec 26, 2018
|
OK, merging this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.rudder.io/issues/13999