Fixes #3073 : add logrotate conf for non compliant report logfile #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| /var/log/rudder/compliance/non-compliant-reports.log { | ||
| daily | ||
| missingok | ||
| rotate 30 |
There was a problem hiding this comment.
This is an important file, I think keeping it for 30 days is not long enough. Change to 365? (same in other files, of course)
|
This looks OK, but is missing the same changes in the initial-promises (./initial-promises/node-server/distributePolicy/logrotate.conf/*). Can you amend, please Vincent ? |
|
I see a new commit was added here, but I did not receive a notification. Please add a comment when a PR needs reviewing again after feedback. Looks fine to me, thanks! Ready to merge. |
|
I thought i commented on the pull request to tell you i made a new commit but it seems that i forgot to validate my comment... sorry ! |
ncharles
added a commit
that referenced
this pull request
Dec 28, 2012
…ort_logger_logrotate_conf Fixes #3073 : add logrotate conf for non compliant report logfile
amousset
pushed a commit
to amousset/rudder-techniques
that referenced
this pull request
Dec 8, 2015
…ogback Fixes #3195 : Add migration script to add non compliant report logger to...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this pull request is linked to http://www.rudder-project.org/redmine/issues/3073
which is a subtask of http://www.rudder-project.org/redmine/issues/3024
which is the integration part of http://www.rudder-project.org/redmine/issues/2988