-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #14353: Remove unencrypted body files #1418
Fixes #14353: Remove unencrypted body files #1418
Conversation
servers => { | ||
"${server}" | ||
}; | ||
encrypt => "true"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is that the default ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good spot it is not actually. This has practically no impact as "When used with protocol_version 2 or greater this attribute is a noop as the entire session is encrypted." but who knows, it's probaly better to keep it anyway.
Commit modified |
@@ -74,30 +51,9 @@ body copy_from copy_digest_without_perms(from) | |||
portnumber => "${system_common.community_port}"; | |||
} | |||
|
|||
# Use for non-sensitive policy files | |||
body copy_from remote_unsecured_without_perms(server, path) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is used in techniques/system/distributePolicy/1.0/propagatePromises.st - you should remove it there also
Commit modified |
This PR is not mergeable to upper versions. |
OK, squash merging this PR |
5999123
to
6156309
Compare
https://issues.rudder.io/issues/14353