Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #14353: Remove unencrypted body files #1418

Merged

Conversation

amousset
Copy link
Member

servers => {
"${server}"
};
encrypt => "true";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is that the default ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good spot it is not actually. This has practically no impact as "When used with protocol_version 2 or greater this attribute is a noop as the entire session is encrypted." but who knows, it's probaly better to keep it anyway.

@amousset
Copy link
Member Author

Commit modified

@@ -74,30 +51,9 @@ body copy_from copy_digest_without_perms(from)
portnumber => "${system_common.community_port}";
}

# Use for non-sensitive policy files
body copy_from remote_unsecured_without_perms(server, path)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is used in techniques/system/distributePolicy/1.0/propagatePromises.st - you should remove it there also

@amousset
Copy link
Member Author

amousset commented Mar 1, 2019

Commit modified

@Normation-Quality-Assistant
Copy link
Contributor

This PR is not mergeable to upper versions.
Since it is "Ready for merge" you must merge it by yourself using the following command:
rudder-dev merge https://github.com/Normation/rudder-techniques/pull/1418
-- Your faithful QA
Kant merge: "Science is organized knowledge. Wisdom is organized life."
(https://ci.normation.com/jenkins/job/merge-accepted-pr/7584/console)

@amousset
Copy link
Member Author

amousset commented Mar 1, 2019

OK, squash merging this PR

@amousset amousset force-pushed the arch_14353/remove_unencrypted_body_files branch from 5999123 to 6156309 Compare March 1, 2019 14:29
@amousset amousset merged commit 6156309 into Normation:master Mar 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants