Fixes #14916: Use umask defined in /etc/login.defs in Technique "SSH authorized keys" for creating missing home dir #1445
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fdall
reviewed
Jun 3, 2019
| # read the /etc/login.defs to get umask for home creation if home dir is not there | ||
| "nb_line_read" int => readstringarray("login_defs_content", "/etc/login.defs","#[^\n]*", "\s+", "99999", "9999999"); | ||
| # Use the umask to get the value | ||
| "homedir_mode_real" string => eval("777-${login_defs_content[UMASK][1]}}", "math", "infix"); |
| "homedir_mode_real" string => eval("777-${login_defs_content[UMASK][1]}}", "math", "infix"); | ||
| # Format to int | ||
| "homedir_mode_int" string => format("%0.0f", ${homedir_mode_real}); | ||
| "homedir_mode_to_use" string => "${homedir_mode_int}"; |
There was a problem hiding this comment.
Why not doing this in one line?
"homedir_mode_to_use" string => format("%0.0f", ${homedir_mode_real});
There was a problem hiding this comment.
because homedir_mode_real may not exist, in this case, the format is not evaluated, and i use the default home_dir_to_use (line 65)
i'm not sure that doing it in one step may not cancel the actual value
… authorized keys\" for creating missing home dir
ncharles
force-pushed
the
bug_14916/use_umask_defined_in_etc_login_defs_in_technique_ssh_authorized_keys_for_creating_missing_home_dir
branch
from
4877ac7
to
9639c15
Compare
|
Commit modified |
Fdall
approved these changes
Jun 3, 2019
|
OK, merging this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.rudder.io/issues/14916