Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #15224: Reorganise system technique to simplify execuing a dingle directive #1461

Conversation

peckpeck
Copy link
Member

"Startup report log" usebundle => startup;
"Initialize ncf" usebundle => initialize_ncf;
"Define environment variables" usebundle => get_environment_variables;
&if(INITIAL)&
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not

"specific_bs" slist => { };
bundle agent common_system_end {
methods:
&if(INITIAL)&
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not

@peckpeck
Copy link
Member Author

PR updated with a new commit

1 similar comment
@peckpeck
Copy link
Member Author

PR updated with a new commit

@peckpeck peckpeck force-pushed the arch_15224/reorganise_system_technique_to_simplify_execuing_a_dingle_directive branch from b217d37 to fe61454 Compare July 16, 2019 16:05
@peckpeck
Copy link
Member Author

PR updated with a new commit

@Normation-Quality-Assistant
Copy link
Contributor

This PR is not mergeable to upper versions.
Since it is "Ready for merge" you must merge it by yourself using the following command:
rudder-dev merge https://github.com/Normation/rudder-techniques/pull/1461
-- Your faithful QA
Kant merge: "In law a man is guilty when he violates the rights of others. In ethics he is guilty if he only thinks of doing so."
(https://ci.normation.com/jenkins/job/merge-accepted-pr/12360/console)

@peckpeck
Copy link
Member Author

OK, squash merging this PR

@peckpeck peckpeck force-pushed the arch_15224/reorganise_system_technique_to_simplify_execuing_a_dingle_directive branch from 613ba8e to 01eddd6 Compare July 18, 2019 08:35
@peckpeck
Copy link
Member Author

merged with a different commit id 4613e91

@peckpeck peckpeck closed this Jul 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants