Fixes #15380: Add the User techniques category to the technique packaging #1485
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amousset
reviewed
Aug 1, 2019
| @@ -0,0 +1,6 @@ | |||
| <xml> | |||
| <name>User Techniques</name> | |||
There was a problem hiding this comment.
This will break if people already have it with a different name IIRC
There was a problem hiding this comment.
We do not push categories to existing configuration-repository directory
There was a problem hiding this comment.
won't it be updated by techique-upgrade mechanism?
There was a problem hiding this comment.
Then the name will be updated like for other categories.
There was a problem hiding this comment.
the name is not updated when changed in the category file, but a new category is created. This is an old known bug.
|
Needs to be retargeted in 5.1 (and te remove this category creation from the postinstall) |
peckpeck
force-pushed
the
arch_15380/add_the_user_techniques_category_to_the_technique_packaging
branch
from
487c308
to
ccaafa7
Compare
|
PR replaced by #1503 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.rudder.io/issues/15380