New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #3089 : add a rudder-stdlib library for rudder's best practises #15
Fixes #3089 : add a rudder-stdlib library for rudder's best practises #15
Conversation
promise_kept => { "${prefix}_kept" }; | ||
promise_repaired => { "${prefix}_repaired" }; | ||
repair_failed => { "${prefix}_failed" , "$({refix}_error" }; | ||
repair_denied => { "${prefix}_denied" , "$({refix}_error" }; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These 2 lines are missing a "p" in "prefix".
The pull request has been updated to take into account your remarks Jon |
{ | ||
methods: | ||
"success" | ||
usebundle => rudder_common_report(technique_name, "result_success", identifier, component_name, component_key, "${message_prefix} was correct"), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you're missing the "${}" on variables in this call... and the two others below :)
{ | ||
reports: | ||
linux|!linux:: | ||
"@@${technique_name}@@${status}@@${identifier}@@${component_name}@@${component_key}@@$(g.execRun)##$(g.uuid)@#${message}"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a detail, but our convention says use
Looks good to me, merging! |
…r_stdlib Fixes #3089 : add a rudder-stdlib library for rudder's best practises
Create the fundation for the rudder-stdlib library