New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #16518: Missing report on "Synchronize files" on simple relays when shared-files are empty #1575
Closed
amousset
wants to merge
214
commits into
Normation:branches/rudder/5.0
from
amousset:bug_16518/missing_report_on_synchronize_files_on_simple_relays_when_shared_files_are_empty
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…branches/rudder/6.0
…e remove_limits.conf from rsyslog config
…9_pr' into branches/rudder/6.0
…lso_remove_remove_limits_conf_from_rsyslog_config_pr' into branches/rudder/6.0
…s when shared-files are empty
@@ -158,7 +158,8 @@ bundle agent propagatePromises | |||
|
|||
pass3.files_propagated.sync_method_rsync:: | |||
"any" usebundle => rudder_common_report("DistributePolicy", "result_success", "${distribute_policy_common.directiveId}", "Synchronize files", "None", "Shared files synchronized using rsync"); | |||
pass3.(files_propagated|(could_not_propagate_files.update_successful)).!sync_method_rsync:: | |||
# Cannot directly use seccess class as it is not defined if there are no files to copy |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seccess => success
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👁️
…e relays when shared-files are empty Fixes #16518: Missing report on \"Synchronize files\" on simple relays when shared-files are empty
PR updated with a new commit |
…n simple relays when shared-files are empty Fixes #16518: Missing report on \"Synchronize files\" on simple relays when shared-files are empty
PR updated with a new commit |
amousset
changed the base branch from
branches/rudder/6.0
to
branches/rudder/5.0
January 9, 2020 16:56
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.rudder.io/issues/16518