-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #18118: Remove syslog configuration from system techniques #1617
Fixes #18118: Remove syslog configuration from system techniques #1617
Conversation
PR updated with a new commit |
PR updated with a new commit |
<NAME>SHARED_FILES_FOLDER</NAME> | ||
<NAME>STORE_ALL_CENTRALIZED_LOGS_IN_FILE</NAME> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ha, this one is a regression - we should be able to use this value to store all log in all.log
maybe a configuration in rudder-relayd ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is awesome to remove so many deprecation
some minor change requested, fot the required variables to delete rsyslog content, and removing ref to check_rsyslog_version in metadata
@@ -1,31 +0,0 @@ | |||
#!/bin/sh |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it should also be removed from the metadata.xml https://github.com/Normation/rudder-techniques/pull/1617/files#diff-3d9c01bf53ab8104c0bc76244daad2f3R78
bundle agent check_log_system | ||
{ | ||
vars: | ||
debian:: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
these variables are used in remove_rudder_syslog_configuration https://github.com/Normation/rudder-techniques/pull/1617/files#diff-75507fb0a9433bdb509596c7d5251f35L525
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good spot!
PR updated with a new commit |
This PR is not mergeable to upper versions. |
OK, squash merging this PR |
a49fae0
to
59d4bc9
Compare
https://issues.rudder.io/issues/18118