Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #18118: Remove syslog configuration from system techniques #1617

Merged
merged 1 commit into from
Aug 31, 2020
Merged

Fixes #18118: Remove syslog configuration from system techniques #1617

merged 1 commit into from
Aug 31, 2020

Conversation

amousset
Copy link
Member

@amousset amousset requested a review from ncharles August 18, 2020 09:09
@amousset
Copy link
Member Author

PR updated with a new commit

@amousset
Copy link
Member Author

PR updated with a new commit

ncharles
ncharles reviewed Aug 19, 2020
View reviewed changes
techniques/system/distributePolicy/1.0/metadata.xml
<NAME>SHARED_FILES_FOLDER</NAME>
<NAME>STORE_ALL_CENTRALIZED_LOGS_IN_FILE</NAME>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ha, this one is a regression - we should be able to use this value to store all log in all.log
maybe a configuration in rudder-relayd ?

ncharles
ncharles requested changes Aug 19, 2020
View reviewed changes
Copy link
Member

@ncharles ncharles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is awesome to remove so many deprecation
some minor change requested, fot the required variables to delete rsyslog content, and removing ref to check_rsyslog_version in metadata

techniques/system/common/1.0/check-rsyslog-version
@@ -1,31 +0,0 @@
#!/bin/sh
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it should also be removed from the metadata.xml https://github.com/Normation/rudder-techniques/pull/1617/files#diff-3d9c01bf53ab8104c0bc76244daad2f3R78

techniques/system/common/1.0/promises.st
bundle agent check_log_system
{
vars:
debian::
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these variables are used in remove_rudder_syslog_configuration https://github.com/Normation/rudder-techniques/pull/1617/files#diff-75507fb0a9433bdb509596c7d5251f35L525

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good spot!

@amousset
Copy link
Member Author

PR updated with a new commit

@Normation-Quality-Assistant
Copy link
Contributor

This PR is not mergeable to upper versions.
Since it is "Ready for merge" you must merge it by yourself using the following command:
rudder-dev merge https://github.com/Normation/rudder-techniques/pull/1617
-- Your faithful QA
Kant merge: "To be is to do."
(https://ci.normation.com/jenkins/job/merge-accepted-pr/29238/console)

@ncharles
Copy link
Member

OK, squash merging this PR

@ncharles ncharles force-pushed the bug_18118/remove_syslog_configuration_from_system_techniques branch from a49fae0 to 59d4bc9 Compare August 31, 2020 20:39
@ncharles ncharles merged commit 59d4bc9 into Normation:master Aug 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ncharles ncharles ncharles approved these changes

Assignees
No one assigned
Labels
qa: Can't merge Trigger test
Projects
None yet
Milestone
No milestone
3 participants
@amousset @Normation-Quality-Assistant @ncharles