Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #18228: Create an "old-school" crontab technique to manage crontab in /var/spool/cron/crontabs #1623

Merged
merged 1 commit into from
Sep 21, 2020
Merged

Fixes #18228: Create an "old-school" crontab technique to manage crontab in /var/spool/cron/crontabs #1623

merged 1 commit into from
Sep 21, 2020

Conversation

ncharles
Copy link
Member

@ncharles
Copy link
Member Author

This works in simple tests, need the reload of cron service

@ncharles
Copy link
Member Author

PR updated with a new commit

amousset
amousset reviewed Sep 18, 2020
View reviewed changes
techniques/system/common/1.0/hooks.cf Outdated
usebundle => clean_reporting_context;


processes:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we have a generic method to check process status using ps.
IIRC cron_bin is part of system techniques and should not be used in normal techniques

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i simply reused what was in cron technique

ncharles
ncharles commented Sep 18, 2020
View reviewed changes
techniques/systemSettings/systemManagement/userCronManagement/1.0/userCronConfiguration.st Outdated
files:
"${cron_base_path}/${cron_user[${cron_index}]}"
create => "true",
perms => mog("600", "${cron_user[${cron_index}]}", "${cron_user[${cron_index}]}"),
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i'm usure of the expected group

@ncharles
Copy link
Member Author

PR updated with a new commit

2 similar comments
@ncharles
Copy link
Member Author

PR updated with a new commit

@ncharles
Copy link
Member Author

PR updated with a new commit

@Normation-Quality-Assistant
Copy link
Contributor

This PR is not mergeable to upper versions.
Since it is "Ready for merge" you must merge it by yourself using the following command:
rudder-dev merge https://github.com/Normation/rudder-techniques/pull/1623
-- Your faithful QA
Kant merge: "To be is to do."
(https://ci.normation.com/jenkins/job/merge-accepted-pr/30162/console)

@ncharles
Copy link
Member Author

OK, squash merging this PR

@ncharles ncharles force-pushed the ust_18228/create_an_old_school_crontab_technique_to_manage_crontab_in_var_spool_cron_crontabs branch 2 times, most recently from fbdae5f to e8d078a Compare September 21, 2020 14:51
@ncharles
Copy link
Member Author

OK, squash merging this PR

@ncharles ncharles force-pushed the ust_18228/create_an_old_school_crontab_technique_to_manage_crontab_in_var_spool_cron_crontabs branch from e8d078a to 3b2ff7e Compare September 21, 2020 15:12
@ncharles ncharles merged commit 3b2ff7e into Normation:branches/rudder/6.2 Sep 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amousset amousset amousset approved these changes

Assignees
No one assigned
Labels
qa: Can't merge
Projects
None yet
Milestone
No milestone
3 participants
@ncharles @Normation-Quality-Assistant @amousset