Fixes #18909: Add an "upgrade only" option to the technique packageManagement #1650

Fdall · 2021-02-16T15:50:03Z

https://issues.rudder.io/issues/18909

Fdall · 2021-02-16T15:50:25Z

this is just an initial commit for reference

Fdall · 2021-02-16T15:51:33Z

PR updated with a new commit

ncharles · 2021-02-17T10:05:18Z

techniques/applications/packageManagement/1.3/metadata.xml

@@ -45,6 +37,10 @@
          <LABEL>Absent</LABEL>
          <VALUE>absent</VALUE>
        </ITEM>
+        <ITEM>
+          <LABEL>Only if already installed</LABEL>


"Upgrade only if already installed" or something like that ?

ncharles · 2021-02-17T10:22:19Z

techniques/applications/packageManagement/1.3/packageManagement.st


  methods:
+    pass1::
+      # Force t oaudit mode to verify if packages are already installed (whatever their version is)


this should be done only if "state_upgrade_only_${index_pkg}"

ncharles · 2021-02-17T10:29:01Z

techniques/applications/packageManagement/1.3/packageManagement.st

@@ -121,5 +156,7 @@ bundle agent package_management_&RudderUniqueID& {

      "report_${index_pkg}"     usebundle => rudder_common_reports_generic_index("packageManagement", "${class_prefix_script[${index_pkg}]}", "${trackingkey[${index_pkg}]}", "Post-modification script", "${package[${index_pkg}]}", "Execution of the post-modification script", "${index_pkg}"),
                               ifvarclass => "posthook_specified_${index_pkg}.${inner_class_prefix_${index_pkg}}_repaired";
+
+  reports:


why the empty report ?

Fdall · 2021-02-17T14:32:10Z

PR updated with a new commit

ncharles

some minor comments.
I'll check the code as well on a rudder instance

ncharles · 2021-03-01T14:38:14Z

techniques/applications/packageManagement/1.3/packageManagement.st


  methods:
+    pass1::
+      # Force to audit mode to verify if packages are already installed (whatever their version is)
+      "remove_dry_run_mode"            usebundle => push_dry_run_mode("true");


shouldn't it be "force dry_run_mode" ? even if it's only a comment, it would help

ncharles · 2021-03-01T14:49:55Z

techniques/applications/packageManagement/1.3/packageManagement.st


-      "report_${index_pkg}" usebundle => rudder_common_reports_generic_index("packageManagement", "${inner_class_prefix_${index_pkg}}", "${trackingkey[${index_pkg}]}", "Package", "${package[${index_pkg}]}", "${state_description[${index_pkg}]} of package ${package[${index_pkg}]}${architecture_description[${index_pkg}]}${version_description[${index_pkg}]}", "${index_pkg}");
+      # Report special case when the state is "upgrade only" and the package was not found on the machine
+      "report_na_${index_pkg}" usebundle => rudder_common_report("packageManagement", "result_na", "${trackingkey[${index_pkg}]}", "Package", "${package[${index_pkg}]}", "Upgrade only set but the package was not found on the machine."),


Suggested change

"report_na_${index_pkg}" usebundle => rudder_common_report("packageManagement", "result_na", "${trackingkey[${index_pkg}]}", "Package", "${package[${index_pkg}]}", "Upgrade only set but the package was not found on the machine."),

"report_na_${index_pkg}" usebundle => rudder_common_report_index("packageManagement", "result_na", "${trackingkey[${index_pkg}]}", "Package", "${package[${index_pkg}]}", "Upgrade only set for package ${package[${index_pkg}]} but this package was not found on the machine.", "${index_pkg}"),

ncharles · 2021-03-01T15:39:31Z

techniques/applications/packageManagement/1.3/packageManagement.st

+    pass1::
+      # Force to audit mode to verify if packages are already installed (whatever their version is)
+      "remove_dry_run_mode"            usebundle => push_dry_run_mode("true");
+      "already_installed_${index_pkg}" usebundle => package_state_options("${package[${index_pkg}]}", "any", "${architecture[${index_pkg}]}", "${manager[${index_pkg}]}", "present", "${manager_final_options[${index_pkg}]}"),


if we have two different technique, one with upgrade only first and the second with install, it will skip the install part and fail

ncharles · 2021-03-01T15:51:29Z

techniques/applications/packageManagement/1.3/packageManagement.st

+    # The pass2 is not strictly necessary but prevent future issues if the behavior of pre-evaluation changes (because the evaluation of vars + classes takes 2 passes)
+    pass2::
+      # Package
+      "package_${index_pkg}" usebundle => package_state_options("${package[${index_pkg}]}", "${version[${index_pkg}]}", "${architecture[${index_pkg}]}", "${manager[${index_pkg}]}", "${ncf_state[${index_pkg}]}", "${manager_final_options[${index_pkg}]}"),


this is not correctly executed
I have reports:
verbose: P: From parameterized bundle: _log_v3( {"Presence of package tree in any version","htop","package_state_options_htop","package_state_options_htop_any_default_default_present_","@{args}"})

when calling first with upgrade only, then present
inverting the order partially solved the issue - package is installed

VinceMacBuche · 2021-03-01T15:55:44Z

techniques/applications/packageManagement/1.3/changelog

+  ** Add options for package managers
+ -- Nicolas Charles <nicolas.charles@normation.com> Thu Dec  7 17:16:30 2017
+  * Version 1.2
+  ** Convert to multiversionned technique


It misses a changelog entry, stating that Felix the great has done this version

Fdall · 2021-03-02T09:15:34Z

PR updated with a new commit

Fdall · 2021-03-02T09:19:20Z

PR updated with a new commit

Fdall · 2021-03-02T09:24:32Z

PR updated with a new commit

ncharles · 2021-03-02T09:53:22Z

techniques/applications/packageManagement/1.3/changelog

+ -- Nicolas Charles <nicolas.charles@normation.com> Thu Dec  7 17:16:30 2017
+  * Version 1.2
+  ** Convert to multiversionned technique
+ -- Félix Dallidet <felix.dallidet@rudder.io> Thu Mar 1 10:23:30 2021


Suggested change

-- Félix Dallidet <felix.dallidet@rudder.io> Thu Mar 1 10:23:30 2021

-- Félix Dallidet <felix.dallidet@rudder.io> Mon Mar 1 10:23:30 2021

ncharles · 2021-03-02T09:53:32Z

techniques/applications/packageManagement/1.3/changelog

+  * Version 1.2
+  ** Convert to multiversionned technique
+ -- Félix Dallidet <felix.dallidet@rudder.io> Thu Mar 1 10:23:30 2021
+  * Version 1.2


Suggested change

* Version 1.2

* Version 1.3

Fdall · 2021-03-02T10:37:42Z

PR updated with a new commit

Normation-Quality-Assistant · 2021-03-02T11:02:58Z

This PR is not mergeable to upper versions.
Since it is "Ready for merge" you must merge it by yourself using the following command:
rudder-dev merge https://github.com/Normation/rudder-techniques/pull/1650
-- Your faithful QA
Kant merge: "Happiness is not an ideal of reason, but of imagination."
(https://ci.normation.com/jenkins/job/merge-accepted-pr/36010/console)

ncharles

it is missing the change of list of maintaine version

Fdall · 2021-03-02T14:51:46Z

PR updated with a new commit

Normation-Quality-Assistant · 2021-03-02T15:29:52Z

This PR is not mergeable to upper versions.
Since it is "Ready for merge" you must merge it by yourself using the following command:
rudder-dev merge https://github.com/Normation/rudder-techniques/pull/1650
-- Your faithful QA
Kant merge: "All our knowledge begins with the senses, proceeds then to the understanding, and ends with reason. There is nothing higher than reason."
(https://ci.normation.com/jenkins/job/merge-accepted-pr/36024/console)

Fdall · 2021-03-03T09:44:53Z

OK, squash merging this PR

…Management

Fdall requested a review from ncharles February 16, 2021 15:50

Fdall added the Trigger test label Feb 16, 2021

Fdall added Trigger test and removed Trigger test labels Feb 16, 2021

ncharles reviewed Feb 17, 2021

View reviewed changes

Fdall added Trigger test and removed Trigger test labels Feb 17, 2021

ncharles requested changes Mar 1, 2021

View reviewed changes

ncharles reviewed Mar 1, 2021

View reviewed changes

VinceMacBuche reviewed Mar 1, 2021

View reviewed changes

Fdall added Trigger test and removed Trigger test labels Mar 2, 2021

ncharles reviewed Mar 2, 2021

View reviewed changes

Fdall added Trigger test and removed Trigger test labels Mar 2, 2021

ncharles approved these changes Mar 2, 2021

View reviewed changes

Normation-Quality-Assistant added the qa: Can't merge label Mar 2, 2021

ncharles requested changes Mar 2, 2021

View reviewed changes

Fdall added Trigger test and removed Trigger test qa: Can't merge labels Mar 2, 2021

ncharles approved these changes Mar 2, 2021

View reviewed changes

Normation-Quality-Assistant added the qa: Can't merge label Mar 2, 2021

Fixes #18909: Add an \"upgrade only\" option to the technique package…

d9ac7c3

…Management

Fdall force-pushed the ust_18909/add_an_upgrade_only_option_to_the_technique_packagemanagement branch from 225abab to d9ac7c3 Compare March 3, 2021 09:44

Fdall merged commit d9ac7c3 into Normation:branches/rudder/6.1 Mar 3, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fixes #18909: Add an "upgrade only" option to the technique packageManagement #1650

Fixes #18909: Add an "upgrade only" option to the technique packageManagement #1650

Fdall commented Feb 16, 2021

Fdall commented Feb 16, 2021

Fdall commented Feb 16, 2021

ncharles Feb 17, 2021

ncharles Feb 17, 2021

ncharles Feb 17, 2021

Fdall commented Feb 17, 2021

ncharles left a comment •

edited

Loading

ncharles Mar 1, 2021

ncharles Mar 1, 2021

ncharles Mar 1, 2021

ncharles Mar 1, 2021 •

edited

Loading

VinceMacBuche Mar 1, 2021

Fdall commented Mar 2, 2021

Fdall commented Mar 2, 2021

Fdall commented Mar 2, 2021

ncharles Mar 2, 2021

ncharles Mar 2, 2021

Fdall commented Mar 2, 2021

Normation-Quality-Assistant commented Mar 2, 2021

ncharles left a comment

Fdall commented Mar 2, 2021

Normation-Quality-Assistant commented Mar 2, 2021

Fdall commented Mar 3, 2021

	"report_na_${index_pkg}" usebundle => rudder_common_report("packageManagement", "result_na", "${trackingkey[${index_pkg}]}", "Package", "${package[${index_pkg}]}", "Upgrade only set but the package was not found on the machine."),
	"report_na_${index_pkg}" usebundle => rudder_common_report_index("packageManagement", "result_na", "${trackingkey[${index_pkg}]}", "Package", "${package[${index_pkg}]}", "Upgrade only set for package ${package[${index_pkg}]} but this package was not found on the machine.", "${index_pkg}"),

	-- Félix Dallidet <felix.dallidet@rudder.io> Thu Mar 1 10:23:30 2021
	-- Félix Dallidet <felix.dallidet@rudder.io> Mon Mar 1 10:23:30 2021

Fixes #18909: Add an "upgrade only" option to the technique packageManagement #1650

Fixes #18909: Add an "upgrade only" option to the technique packageManagement #1650

Conversation

Fdall commented Feb 16, 2021

Fdall commented Feb 16, 2021

Fdall commented Feb 16, 2021

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Fdall commented Feb 17, 2021

ncharles left a comment • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ncharles Mar 1, 2021 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Fdall commented Mar 2, 2021

Fdall commented Mar 2, 2021

Fdall commented Mar 2, 2021

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Fdall commented Mar 2, 2021

Normation-Quality-Assistant commented Mar 2, 2021

ncharles left a comment

Choose a reason for hiding this comment

Fdall commented Mar 2, 2021

Normation-Quality-Assistant commented Mar 2, 2021

Fdall commented Mar 3, 2021

ncharles left a comment •

edited

Loading

ncharles Mar 1, 2021 •

edited

Loading