Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #19121: Cleanup apache_acl bundle in the system technique DistributePolicy #1660

Conversation

Fdall
Copy link
Contributor

@Fdall Fdall commented Apr 2, 2021

@Fdall Fdall requested a review from amousset April 2, 2021 14:33
Copy link
Member

@ncharles ncharles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some minor changes

@@ -2,14 +2,24 @@ bundle agent apache_acl
{

vars:
"destination" string => "${g.rudder_var}/lib/ssl/";
"technique_name" string => "DistributePolicy";
"trackingkey " string => "${distribute_policy_common.directiveId}";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

extra space in the " " here

techniques/system/distributePolicy/1.0/apache-acl.cf Outdated Show resolved Hide resolved
@Fdall
Copy link
Contributor Author

Fdall commented Apr 12, 2021

PR updated with a new commit

@Normation-Quality-Assistant
Copy link
Contributor

This PR is not mergeable to upper versions.
Since it is "Ready for merge" you must merge it by yourself using the following command:
rudder-dev merge https://github.com/Normation/rudder-techniques/pull/1660
-- Your faithful QA
Kant merge: "Happiness is not an ideal of reason, but of imagination."
(https://ci.normation.com/jenkins/job/merge-accepted-pr/37582/console)

@Fdall
Copy link
Contributor Author

Fdall commented Apr 30, 2021

OK, squash merging this PR

@Fdall Fdall force-pushed the arch_19121/cleanup_apache_acl_bundle_in_the_system_technique_distributepolicy branch from 52c941a to 2694064 Compare April 30, 2021 08:17
@Fdall Fdall merged commit 2694064 into Normation:master Apr 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants