Fixes #19560: Rename the AUTHORIZED_NETWORKS parameter used in the common system techniques. #1690
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ncharles
reviewed
Jul 26, 2021
| @@ -92,9 +92,9 @@ bundle common def | |||
| policy_server:: | |||
| "acl" slist => { | |||
| "127.0.0.0/8" , "::1", @{sys.ip_addresses}, | |||
| &if(AUTHORIZED_NETWORKS)& | |||
| &if(ALLOWEDNETWORKS)& | |||
There was a problem hiding this comment.
Suggested change
| &if(ALLOWEDNETWORKS)& | |
| &if(ALLOWED_NETWORKS)& |
ncharles
requested changes
Jul 26, 2021
fanf
reviewed
Jul 26, 2021
| @@ -76,7 +76,6 @@ | |||
| </FILES> | |||
|
|
|||
| <SYSTEMVARS> | |||
| <NAME>AUTHORIZED_NETWORKS</NAME> | |||
There was a problem hiding this comment.
it's still used in common technique as a system var, you need to call it ALLOWED_NETWORKS here
…mmon system techniques.
Fdall
force-pushed
the
arch_19560/rename_the_authorized_networks_parameter_used_in_the_common_system_techniques
branch
from
9b7aeb8
to
4e4afcd
Compare
|
Commit modified |
fanf
approved these changes
Jul 26, 2021
fanf
approved these changes
Jul 26, 2021
|
OK, merging this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.rudder.io/issues/19560