Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #19584: when the password are updated by the policies, rudder-jetty and rudder-slapd are not restarted #1698

Conversation

ncharles
Copy link
Member

@@ -50,4 +55,5 @@ bundle agent system_rudder_webapp_properties {
"any" usebundle => _method_reporting_context("Check webapp configuration", "webdav password");
"any" usebundle => file_key_value_present("${properties_file}", "rudder.webdav.password", "${dav_password[2]}", "=");

file_key_value_present__opt_rudder_etc_rudder_web_properties_repaired
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like a copy/paste fail

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TOTALLY

@ncharles
Copy link
Member Author

PR updated with a new commit

@ncharles
Copy link
Member Author

don't merge, it doesn't restart rudder-relayd

@ncharles
Copy link
Member Author

PR updated with a new commit

@@ -46,7 +46,7 @@ bundle agent system_reload_rudder_services {
rudder_server_system_restart_apache::
"any" usebundle => service_reload("${apache_service_name}");
rudder_server_system_restart_relayd::
"any" usebundle => service_reload("${relayd_service_name}");
"any" usebundle => service_start("${relayd_service_name}");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"any" usebundle => service_start("${relayd_service_name}");
"any" usebundle => service_restart("${relayd_service_name}");

@ncharles
Copy link
Member Author

PR updated with a new commit

@Normation-Quality-Assistant
Copy link
Contributor

OK, squash merging this PR

@Normation-Quality-Assistant Normation-Quality-Assistant force-pushed the bug_19584/when_the_password_are_updated_by_the_policies_rudder_jetty_and_rudder_slapd_are_not_restarted branch from b5a1979 to 63a6f00 Compare July 28, 2021 14:32
@Normation-Quality-Assistant Normation-Quality-Assistant merged commit 63a6f00 into Normation:master Jul 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants