Fixes #20427: missing default value in initial promises #1740
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amousset
reviewed
Dec 14, 2021
Makefile
Outdated
| @@ -59,6 +59,8 @@ initial-promises: rudder-templates-cli.jar test | |||
| touch initial-promises/rudder_expected_reports.csv | |||
| # Provide a default rudder.json | |||
| cp variables.json initial-promises/node-server/rudder.json | |||
| # Provide a default rudder-parameters.json | |||
| cp rudder-parameters.json initial-promises/node-server/rudder-parameters.json | |||
There was a problem hiding this comment.
rudder parameters are defined as rudder.${namespaces} but we need node properties here.
|
PR updated with a new commit |
amousset
reviewed
Dec 14, 2021
properties.json
Outdated
| "updates_cache_expire":240 | ||
| }, | ||
| "server":{ | ||
| "cf_serverd_bind_address":"192.168.45.2" |
There was a problem hiding this comment.
i'm adding an extra layer of security
|
PR updated with a new commit |
amousset
approved these changes
Dec 14, 2021
|
This PR is not mergeable to upper versions. |
|
OK, squash merging this PR |
amousset
force-pushed
the
ust_20427/missing_default_value_in_initial_promises
branch
from
c85e818
to
063da3c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.rudder.io/issues/20427