Fixes #21617: Permissions are not preserved in shared-files on the relays #1778
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PR updated with a new commit |
amousset
commented
Aug 18, 2022
| @@ -115,6 +115,7 @@ bundle agent propagate_promises(trackingkey, technique_name, relay_sync_method, | |||
| "${g.shared_files}" | |||
| copy_from => remote("${server_info.policy_server}","${g.shared_files}"), | |||
| depth_search => recurse_visible("inf"), | |||
| perms => mog("640", "root", "rudder"), | |||
There was a problem hiding this comment.
not sure about this, we may need to preserver permissions instead
There was a problem hiding this comment.
I'l check how it could work before
There was a problem hiding this comment.
Apparently we didn't preserve perms there back in 3.1, so let's assume we don't need it.
VinceMacBuche
approved these changes
Aug 22, 2022
|
OK, squash merging this PR |
Normation-Quality-Assistant
force-pushed
the
bug_21617/permissions_are_not_preserved_in_shared_files_on_the_relays
branch
from
485909b
to
f52c382
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.rudder.io/issues/21617