Fixes #22591: Variable from JSON file don't report in Rudder 7.2 #1816
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ncharles
reviewed
May 29, 2023
| @@ -27,7 +27,7 @@ For example a JSON containing `{ "datacenter": "paris" }` read into the variable | |||
| </TRACKINGVARIABLE> | |||
|
|
|||
| <SECTIONS> | |||
| <SECTION name="Base file" component="true" componentKey="VARIABLE_FROM_JSON_FILE_JSON_FILE" /> | |||
| <SECTION name="Base file" component="true" componentKey="VARIABLE_FROM_JSON_FILE_BASE_FILE" /> | |||
There was a problem hiding this comment.
i'm dubious that it might work given that the componentKey is not related to the trackingVariable
|
with this PR, the situation is much worse, as the reporting get more invalid than withtout it
|
|
This is an old PR and latest test tends to show that it does introduce new bugs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.rudder.io/issues/22591