Fixes #3950,#3951: Added an new version of motdConfiguration enabling th... #191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| ################################################### | ||
|
|
||
| bundle edit_line prepend(lines) | ||
| bundle edit_line rudder_line_insertion(lines, location) |
There was a problem hiding this comment.
We should never, ever, rename bodies or bundles in shared libraries. There may be many Techniques out there using them.
Just add a new bundle/body if you need to.
|
This contains unrelated changes in initial promises and other Techniques. Aside from them, and the one comment I made about a description this looks fine. Please clean up the other changes, and we're good to go! |
|
Updated ! |
… the user to select where should the MOTD be added
jooooooon
added a commit
that referenced
this pull request
Sep 23, 2013
…end_start_option_to_motdconfiguration Fixes #3950,#3951: Added an new version of motdConfiguration enabling th...
amousset
pushed a commit
to amousset/rudder-techniques
that referenced
this pull request
Dec 8, 2015
…x_ncf_version Fix NCF changelog version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...e user to select where should the MOTD be added
Ticket: http://www.rudder-project.org/redmine/issues/3951
To be merged in 2.4