Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #4354: correct the wording on Download a file for the shared folde... #304

Conversation

ncharles
Copy link
Member

...r for copying folder

@@ -67,7 +67,7 @@ The default location of the shared folder is /var/rudder/configuration-repositor
</ITEM>
<ITEM>
<VALUE>inf</VALUE>
<LABEL>The folder, its content, and all the subfolders</LABEL>
<LABEL>The folder of the folder, and all its subfolders</LABEL>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This text makes no sense. Please amend.

@jooooooon
Copy link
Member

This looks OK, but since the original reporter of the ticket complained that it was not obvious that he had to specify the name of the destination folder, we should include that as a tip too. Could you add that?

@ncharles
Copy link
Member Author

ncharles commented Mar 4, 2014

Would the following text be ok for you?
"If you wish to copy a folder, only the content of the folder will be copied, so you may have to specify its name in the destination if you wish to retain it"

@jooooooon
Copy link
Member

Let's go with:

"If you're copying a folder, this option will only copy it's contents. Specify the full path to the containing folder in the destination above" (or maybe "below", I don't know, check the technique).

Can we also add either:
"This folder must already exist."
or
"This folder will be created if it doesn't exist."
(depending on the truth)

@ncharles
Copy link
Member Author

ncharles commented Mar 4, 2014

PR updated !

jooooooon added a commit that referenced this pull request Mar 4, 2014
…_doawnload_from_shared_folder

Fixes #4354: correct the wording on Download a file for the shared folde...
@jooooooon jooooooon merged commit 5c73529 into Normation:branches/rudder/2.6 Mar 4, 2014
amousset pushed a commit to amousset/rudder-techniques that referenced this pull request Dec 8, 2015
…date_fusion_to_2_3_6_in_rudder_2_11

Ust 4594/int/4760 update fusion to 2 3 6 in rudder 2 11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants