Int 5035/adapt initial promises to only check components when present #416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| # These roles are auto-detected by default, based on inventories of nodes that have role files in /opt/rudder/etc/server-roles.d/ | ||
| # Format is the following | ||
| # role:hostname1,hostname2,hostname3 | ||
| rudder-ldap:localhost |
There was a problem hiding this comment.
it should be rudder-inventory-endpoint and rudder-inventory-ldap
There was a problem hiding this comment.
I thought we decided on rudder-inventory-endpoint and rudder-ldap?
There was a problem hiding this comment.
I meant rudder-inventory-endpoint and rudder-ldap
| ifvarclass => "file_error"; | ||
|
|
||
| policy_server.!root_server:: | ||
|
|
||
| "@@server-roles@@result_success@@server-roles@@server-roles-directive@@2@@Check rudder-passwords.conf and pgpass files@@None@@${g.execRun}##${g.uuid}@#The Rudder passwords file does not need to be checked on relay servers. Skipping..."; |
There was a problem hiding this comment.
Oops, I copied these from a real generation. I will replace all by "0".
|
Aside from the 2 remarks, and the comment missing, this looks good |
|
PR updated. I added two separate commits to see easily the reports modifications (s/2/0/), and the actual changes. |
|
that seems correct, and cf-promises agrees :) |
ncharles
added a commit
that referenced
this pull request
Jun 15, 2014
…s_to_only_check_components_when_present Int 5035/adapt initial promises to only check components when present
amousset
pushed a commit
to amousset/rudder-techniques
that referenced
this pull request
Dec 8, 2015
…x_pip_on_sles Fixes #5167: Use pip 1.2.1 on SLES to prevent OpenSSL related problems
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the initial promises equivalent of #383