Fixes #5429: remove use of curl proxy on Windows #466
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ncharles
force-pushed
the
bug_5429/dev/no_proxy_on_windows
branch
from
b027738
to
d51c09f
Compare
|
@ncharles This looks OK to me, given explanations that curl on windows doesn't support proxies. Please rebase and merge. |
|
i'll change it to use the --noproxy option, which is the right way on windows |
|
Better still! |
ncharles
force-pushed
the
bug_5429/dev/no_proxy_on_windows
branch
from
d51c09f
to
f614de2
Compare
|
PR updated, could you review it @jooooooon |
|
Looks good to me! Seems that this would have been a more elegant way to do this, including on Linux/UNIX actually. Oh well. |
jooooooon
added a commit
that referenced
this pull request
Oct 8, 2014
Fixes #5429: remove use of curl proxy on Windows
amousset
pushed a commit
to amousset/rudder-techniques
that referenced
this pull request
Dec 8, 2015
…e_promises Fixes #5420: Copy tools by running propagatePromises after init
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.