Fixes #5580: check the monotony of promises timestamp #531
Conversation
| "${g.rudder_tools_updated_origin}" | ||
| create => "true", | ||
| edit_defaults => empty, | ||
| edit_line => insert_lines("${sys.date}"), | ||
| edit_line => insert_lines("${sys.systime}"), |
There was a problem hiding this comment.
doesn't this append a new line each time ? ending with a full history of timestamps ?
There was a problem hiding this comment.
no, edit_defaults empty empties the file, so it can contain only one line
|
It's all good for me |
|
@peckpeck if it's all good, can you merge it ? |
|
Let me review this first. |
|
@ncharles This PR is not mergeable anymore |
|
On 3 April 2015 10:35:49 CEST, peckpeck notifications@github.com wrote:
If I recall correctly, we decided not to merge this change to reduce risk, and keep it for a better time. Maybe 3.1 is a good time for this? I don't think I have reviewed it, so don't worry.Sent from Kaiten Mail. Please excuse my brevity. |
|
@ncharles any update ? |
|
For what it's worth, I have now reviewed this code and it looks good to me. I just have one question: How does the rudder_tools_updated_origin file get created initially? The code here won't create it if it's missing, this is why I ask (but it could easily be changed to do so - maybe it should by default so that there is no risk of it not existing?) I propose to merge this into master (for 3.2 / 4.0 version) soon, so that we have extensive testing during the next few months before it hits a release. |
|
The file is created in distributePolicy/1.0/propagatePromises.cf , when tools are copied on the rudder root server |
|
replaced by #735 |
No description provided.