Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #5643: add support for environment variable through ${node.env[XXX... #538

Closed
wants to merge 1 commit into from
Closed

Fixes #5643: add support for environment variable through ${node.env[XXX... #538

wants to merge 1 commit into from

Conversation

ncharles
Copy link
Member

...]} notation

@ncharles ncharles mentioned this pull request Oct 16, 2014
Closed
@peckpeck
Copy link
Member

I'm OK with this code.
But since this will be included everywhere I'd like @jooooooon to have a look too.

@ncharles
Copy link
Member Author

ok, in this case you should reassign the ticket. I'll do it

@jooooooon
Copy link
Member

@ncharles Could you please resubmit this PR on the 3.0 branch?

@ncharles
Copy link
Member Author

Replaced by #564

@ncharles ncharles closed this Nov 25, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@ncharles @peckpeck @jooooooon