Fixes #5845: Add portable init services handling in the Techniques #574
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kegeruneku
force-pushed
the
bug_5451/dev/5451_add_systemd_support_to_techniques
branch
from
95a756e
to
35c2b39
Compare
Kegeruneku
changed the title
| @@ -128,6 +121,14 @@ bundle agent check_openvpn_client_configuration | |||
|
|
|||
| methods: | |||
|
|
|||
| openvpn_bin_present.ovpn_client_autostart:: | |||
There was a problem hiding this comment.
ovpn_client_autostart was not there when using commands, see below
There was a problem hiding this comment.
It is defined by:
# Autostart ?
"ovpn_client_autostart" expression => strcmp("&OVPN_CLIENT_AUTOSTART&","true");
Actually, I do want to only bootstart ovpn if this class is here :)
|
Cool, a lot of better code ! |
Kegeruneku
force-pushed
the
bug_5451/dev/5451_add_systemd_support_to_techniques
branch
from
35c2b39
to
d186dcf
Compare
|
Updated ! |
|
|
||
| "restart_apache" usebundle => service_restart("httpd"); | ||
|
|
||
| !redhat.apache_bin_present.apache_unbootstarted:: |
There was a problem hiding this comment.
The apache_unbootstarted class was defined by some code that you removed above. You can't use it, therefore. But you shuoldn't have too, the point of the method you're calling is to ensure it's set to start on boot, so you can just call it unconditionally!
Kegeruneku
force-pushed
the
bug_5451/dev/5451_add_systemd_support_to_techniques
branch
from
d186dcf
to
41a8c36
Compare
|
Updated ! |
Kegeruneku
force-pushed
the
bug_5451/dev/5451_add_systemd_support_to_techniques
branch
from
41a8c36
to
cbc4e27
Compare
peckpeck
added a commit
that referenced
this pull request
Nov 28, 2014
…_support_to_techniques Fixes #5845: Add portable init services handling in the Techniques
amousset
pushed a commit
to amousset/rudder-techniques
that referenced
this pull request
Dec 8, 2015
…_not_use_non_posix_shell_bits Fixes #6032: Prevent rudder-inventory-ldap post installation script to o...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket: http://www.rudder-project.org/redmine/issues/5845
To be merged in 3.0