Bug 5889/dev/service management on windows #589
Conversation
ncharles
force-pushed
the
bug_5889/dev/service_management_on_windows
branch
from
45e5080
to
8bfd39b
Compare
| @@ -105,6 +110,7 @@ necessary and kill undesired processes. | |||
| <SELECT1> | |||
| <NAME>PROCESS_MANAGED_KILLING_METHOD</NAME> | |||
| <DESCRIPTION>When stopping this process</DESCRIPTION> | |||
| <LONGDESCRIPTION>This parameter is not used on Windows system</LONGDESCRIPTION> | |||
|
This looks good aside from typos. However, we'll need to prepare an equivalent patch for version 3.0 of this Technique on the 3.0 branch. Could you do that soon, so that we can merge the two together please? |
ncharles
force-pushed
the
bug_5889/dev/service_management_on_windows
branch
from
8bfd39b
to
868e881
Compare
|
PR updated |
| @@ -29,7 +29,8 @@ necessary and kill undesired processes. | |||
| <OS version=">= 4 (Etch)">Debian</OS> | |||
| <OS version=">= 4 (Nahant)">RHEL / CentOS</OS> | |||
| <OS version=">= 10 SP1 (Agama Lizard)">SuSE LES / DES / OpenSuSE</OS> | |||
| <AGENT version=">= 3.2">cfengine-community</AGENT> | |||
| <OS version=">= 2003">Windows</OS> | |||
| <AGENT version=">= 3.5">cfengine-community</AGENT> | |||
There was a problem hiding this comment.
Please also add a line for cfengine-enterprise.
|
Great! I added one more comment (I missed that originally, sorry). What about the PR for the 3.0 branch? |
|
the PR for branch 3.0 is harder than expected, all the code changed :/ |
|
i'll need some more time to do it in 3.0, as i need to bring the windows infra up to date with 3.0beta to correctly test |
|
OK... But could you already open the PR (and a ticket, obviously) with what you think will work for the 3.0 branch? I'm really worried this will get forgotten. |
|
the ticket is already open, but i can't make the pr yet |
|
ok, for the branch 3.0, most of the code has to go to ncf, as it rely on ncf generic methods |
|
Great! That will improve ncf and probably make this PR a lot simpler too. |
ncharles
force-pushed
the
bug_5889/dev/service_management_on_windows
branch
from
868e881
to
51c02dd
Compare
|
PR updated |
|
The PR is now in #609 |
|
Since #609 is looking good, let's backport the latest technique version from the 3.0 branch to 2.11. |
|
Replaced by #611 |
…x_missing_then_in_ldap_postinst Fixes #6120: Add a missing 'then' in rudder-inventory-ldap postinstall s...
No description provided.