Fixes #5190: Redirect the output of Rudder crontab to dev null #596
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
See #597 too |
| @@ -152,5 +158,7 @@ bundle edit_line cron_cleanup | |||
| "0,5,10,15,20,25,30,35,40,45,50,55 \* \* \* \* root if \[ ! -e /opt/rudder/etc/disable-agent -a \`ps -efww \| grep -E \"\(cf-execd\|cf-agent\)\" \| grep -E \"/var/rudder/cfengine-community/bin/\(cf-execd\|cf-agent\)\" \| grep -v grep \| wc -l\` -eq 0 ]; then /var/rudder/cfengine-community/bin/cf-agent -f failsafe.cf \&\& /var/rudder/cfengine-community/bin/cf-agent; fi"; | |||
| # Remove entry with wrong escapements from /etc/crontab | |||
| "0,5,10,15,20,25,30,35,40,45,50,55 \* \* \* \* root if \[ ! -e /opt/rudder/etc/disable-agent -a \`ps -efww \| grep -E \"\(cf-execd\|cf-agent\)\" \| grep -E \"/var/rudder/cfengine-community/bin/\(cf-execd\|cf-agent\)\" \| grep -v grep \| wc -l\` -eq 0 ]; then /var/rudder/cfengine-community/bin/cf-agent -f failsafe.cf \\\&\\\& /var/rudder/cfengine-community/bin/cf-agent; fi"; | |||
| # Remove old AIX entry | |||
| "0,5,10,15,20,25,30,35,40,45,50,55 \* \* \* \* if \[ -x /opt/rudder/bin/check-rudder-agent \]; then /opt/rudder/bin/check-rudder-agent; fi"; | |||
There was a problem hiding this comment.
The bundle you've added this in is an old, deprecated bundle. See the comment above it:
# This is to cleanup /etc/crontab from pre-2.5 usage
# and initial promises before 2.7
We should therefore remove it in Rudder 3.0. And therefore, I don't think it's a good place to set the cleanup for AIX... Could you move it? You can probably just use a standard bundle edit_line delete_lines_matching(regex) (from the CFEngine stdlib).
Kegeruneku
force-pushed
the
bug_5190/dev/5190_redirect_output_of_crontab_to_dev_null
branch
from
5c9423c
to
a0a97f0
Compare
|
Updated |
jooooooon
added a commit
that referenced
this pull request
Dec 5, 2014
…tput_of_crontab_to_dev_null Fixes #5190: Redirect the output of Rudder crontab to dev null
amousset
pushed a commit
to amousset/rudder-techniques
that referenced
this pull request
Dec 8, 2015
…ent_code_is_a_bashism Fixes #6169: Error management code is a bashism
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket: http://www.rudder-project.org/redmine/issues/5190
To be merged in 2.10
Will require manual adjustment to 3.0