Fixes #7038: When promises could have been updated, we still have the… #727
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… error messages saying we couldn't update promises
| repair_timeout => { "${else}" }; | ||
|
|
||
| cancel_kept => { "${else}" }; | ||
| cancel_repaired => { "${else}" }; |
There was a problem hiding this comment.
Shouldn't there be "${if}" in cancel_kept and "${kept}" too in cancel_repaired ?
There was a problem hiding this comment.
I'm not sure it would be relevant. If we cancel the repaired class as well, we'll most likely hide the update that occured, and user may scratch their head on why promises are updated, but report kept
There was a problem hiding this comment.
So we'll report both a kept and repaired status ?
There was a problem hiding this comment.
no, the code is clever, and report the worse state (repaired in case of success and repaired, error in case of repaired and error, etc)
|
Merging |
peckpeck
added a commit
that referenced
this pull request
Jul 28, 2015
…ve_been_updated_we_still_have_the_error_messages_saying_we_couldn_t_update_promises Fixes #7038: When promises could have been updated, we still have the…
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… error messages saying we couldn't update promises