Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #7203: fusionAgent.cf for ARM #746

Closed

Conversation

frbayart
Copy link
Contributor

  • remove hidden charaters
  • avoid dmidecode usage on armv6l and armv7l but read Serial line in /proc/cpuinfo

@@ -58,16 +58,16 @@ bundle agent doInventory

vars:

# If curl is available, use it
# If curl is available, use it
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for these :)

@peckpeck
Copy link
Member

Thank you, that's good to see new contributor and see a quality patch.
Would you be kind enough to correct the $() for the correctness nazi I am ?
Otherwise I will do it during merge.
If you are using rudder-dev, it's a matter of: edit file; git add file; rudder-dev amend

@peckpeck
Copy link
Member

@frbayart
Copy link
Contributor Author

I have replaced $() to ${}

@peckpeck
Copy link
Member

peckpeck commented Jun 7, 2016

Hello @frbayart.
Tince this PR cannot be merged anymore, I took your commits and put them in a new PR #970
Thank you for your time

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants