Fixes #6714: Compress ldap backups #756
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amousset
pushed a commit
to amousset/rudder-techniques
that referenced
this pull request
Dec 8, 2015
…rror_in_specfile_on_rudder_agent Fixes #7258: Syntax error in specfile on rudder-agent
|
Any chance this gets merged @peckpeck ? :-) |
| # Select a file using a pattern # | ||
| ######################################################################## | ||
|
|
||
| body file_select simple_pattern(pattern) |
There was a problem hiding this comment.
This body already exists in cfengine stdlib and is called "by_name"
There was a problem hiding this comment.
Fixed, also rebased to latest 2.11, which fixed the previously bad ${g.gzip} variable
matya
force-pushed
the
patch-6714-compress-ldap-backups
branch
from
cc01d92
to
80c5d01
Compare
| "/var/rudder/ldap/backup" | ||
| file_select => by_name("@{backups_pattern}"), | ||
| depth_search => recurse("0"), | ||
| transformer => "${g.rudder_gzip} \"${this.promiser}\""; |
|
Hello @matya could you change the gzip line ? |
Every time slapd is restarted, it writes a backup, that can get big in time. This modification compresses every uncompressed ldif-backups with gzip just like the webapp-logs.
matya
force-pushed
the
patch-6714-compress-ldap-backups
branch
from
80c5d01
to
a816a6c
Compare
|
@peckpeck done. |
|
Good, merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Every time slapd is restarted, it writes a backup, that can get big in time
This modification compresses every uncompressed ldif-backups with gzip just
like the webapp-logs.