Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #7417: Merge error from #7190 - extra code appeared in 3.1 branch (that does nothing harmful) #768

Conversation

jooooooon
Copy link
Member

action => immediate,
move_obstructions => "true",
classes => success("config", "no_update", "config_ok");

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the block added from the erroneous merge - see fd5b81c?w=1#diff-9f66b723ef155b2f50014b41c8e47a38R230

@jooooooon
Copy link
Member Author

Actually please don't merge this yet, a piece is missing

@jooooooon
Copy link
Member Author

PR updated

@jooooooon jooooooon force-pushed the bug_7417/merge_error_from_7190_extra_code_appeared_in_3_1_branch_that_does_nothing_harmful branch from 7f27260 to 4abf6b7 Compare November 17, 2015 08:48
@jooooooon
Copy link
Member Author

PR updated

@jooooooon jooooooon force-pushed the bug_7417/merge_error_from_7190_extra_code_appeared_in_3_1_branch_that_does_nothing_harmful branch from 4abf6b7 to 0282afa Compare November 17, 2015 08:48
@jooooooon
Copy link
Member Author

OK, good to go again

@ncharles
Copy link
Member

such weirdness

ncharles added a commit that referenced this pull request Nov 17, 2015
…_extra_code_appeared_in_3_1_branch_that_does_nothing_harmful

Fixes #7417: Merge error from #7190 - extra code appeared in 3.1 branch (that does nothing harmful)
@ncharles ncharles merged commit bf52173 into Normation:branches/rudder/3.1 Nov 17, 2015
amousset pushed a commit to amousset/rudder-techniques that referenced this pull request Dec 8, 2015
…iet_during_build

Fixes #7317: Make maven quiet during build
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants