Fixes #7460: Keep all outputs in disabled reporting mode #781
Conversation
| @@ -139,7 +139,7 @@ bundle agent rudder_common_report_index(technique_name, status, identifier, comp | |||
| action => immediate; | |||
|
|
|||
| reports: | |||
| full_compliance|send_reports:: | |||
| full_compliance|reports_disabled|send_reports:: | |||
There was a problem hiding this comment.
I don't like writing "print a report if reports are disabled". It just doesn't make sense.
But we do need to read these reports!
I propose instead:
!changes_only|(changes_only.send_reports)
There was a problem hiding this comment.
do we really want to have even success in no reports ?
There was a problem hiding this comment.
I think so, since you only have the outputs You are not able to understand what was done
At least in changes-only you can look into rudder compliance reporting
There was a problem hiding this comment.
+1 on the change, yes. It's particularly hard to debug if you only see half of the error messages!
|
PR updated |
VinceMacBuche
force-pushed
the
bug_7460/keep_all_outputs_in_disabled_reporting_mode
branch
from
af78763
to
77f98c8
Compare
|
Updated the logic to set the class to be more readable and replace send_reports by log_reports which is more accurate on the intent |
|
OK Merging |
…in_disabled_reporting_mode Fixes #7460: Keep all outputs in disabled reporting mode
…et_during_build Fixes #7370: make wget quiet during build
https://www.rudder-project.org/redmine/issues/7460