Fixes #7598: Adding new features and timezones

[matya]

• NTP Servers
  • can hold multiple server in one line, separated by commas
  • final list is stripped of duplicates
• Timezones
  • Adding all standard timezones
  • Allowing textbox (useful for variable usage)
• RTC Clock
  • Allow to be set to UTC or Localtime or not change
  • Is only set on systems actually having an RTC clock
• Xen Time
  • New feature: Allow setting of Xen Hypervisor time via Dom0

[ncharles]

ha, commit is too big for me to comment on it
So, the bundle list in metadata is not correct ( https://github.com/matya/rudder-techniques/blob/matya-7598-add-features-to-timesettings/techniques/systemSettings/misc/clockConfiguration/4.0/metadata.xml#L33 ). You should have two entries NAME, one for each bundle

[ncharles]

i am amazed that it does work !

[matya]

Just some cascaded splitting logic

[ncharles]

this is one huge PR ! thank you very much for it, I've made some remark about the some minor points, that should be adressed
I have a question also: what happens if we set CLOCK_HWSYNC_RTC and a timezone on windows ? Doesn't it conflict (it would run tzutil even if not necessary, isn't it ?)

[matya]

@ncharles Some short explanation what's going on...
RTC time and the Timezone of Windows are two different settings, however, they influence each other.

1. RTC is the Real-Time Clock, that ticks on every motherboard, and sets the date/time on boot, before NTP can kick in. Useful if you have Databases starting before NTP, or for your log files not having a timejump from t=0 to t=...
2. UTC is the "Coordinated Universal Time", which has no Timezone, no Leapsecond, and should actually be used to feed the RTC...
   ... however, by default Windows stores Local time in the RTC, and this depends on the timezone set. When you enable UTC for RTC and set a Timezone, windows should set the RTC always to UTC and the displayed time would depend on the Timezone.

I have currently no way of testing this additional code on a windows-client with NOVA, so the code currently is only "theoretical". After some google-work I found, that this registry-setting seem fail to work starting from Win8+: Hardware Clock in UTC

This was introduced because of the well-known PEBKAC-Problem, which hit the american people with their time difference even more in the early days, and now they are just keeping it for "historical reasons": Why does Windows keep your BIOS clock on local time?

I could throw it out, then the feature-set would stay as version 3.0, so no worsening on that, or this would need testing and would work with Win7 if I bet correctly... The call is yours which way to go ;-)

[matya]

@ncharles After our discussion on IRC I'll close this to split up the portions in different tickets and PR's