Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #7690: Use classic protocol in Rudder 3.2 #830

Conversation

amousset
Copy link
Member

@peckpeck
Copy link
Member

OK, good, but why not in 2.11 ? especially for system techniques

@peckpeck
Copy link
Member

Lets backport it later

peckpeck added a commit that referenced this pull request Dec 24, 2015
…n_rudder_3_2

Fixes #7690: Use classic protocol in Rudder 3.2
@peckpeck peckpeck merged commit 935b6b3 into Normation:branches/rudder/3.2 Dec 24, 2015
@ncharles
Copy link
Member

protocl_version was introduced in 3.6, so won't work on 3.5
We need to keep the compatibility with previous version of Rudder in Rudder <3.1 (unless stated otherwise)
So only Rudder 3.2 will have this fix

@peckpeck
Copy link
Member

2.11 if cfengine 3.6
And older server will give their promises to newer agents from their system techniques, so newer agent won't be able to talk to older server.

@ncharles
Copy link
Member

@peckpeck no, server 2.11 may still server agent 2.10, and so it will break.

@ncharles
Copy link
Member

and if you use agent 3.2 with server 2.11, it will use classic protocol, same for agent 3.1 with server 3.2

@peckpeck
Copy link
Member

It detects the server version before choosing the protocol ?

@ncharles
Copy link
Member

CFEngine 3.6 uses classical by defaut.
If any of the two use classical, the protocol used is classical

@peckpeck
Copy link
Member

ok

@ncharles
Copy link
Member

this is why agent 3.1 + server 3.2 works with NAT system, but without this patch, agent 3.2 and server 3.2 does not

@amousset
Copy link
Member Author

yes but agent 3.2 with any server from 2.11 will use TLS as it is supported by the server.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants