Fixes #7504: Add test for rudder-techniques to ensure removed deprecated techniques don't come back in an erroneous merge #841
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ted techniques don't come back in an erroneous merge
jooooooon
force-pushed
the
arch_7504/add_test_for_rudder_techniques_to_ensure_removed_deprecated_techniques_don_t_come_back_in_an_erroneous_merge
branch
from
21f146e
to
eb7c390
Compare
|
PR updated |
| ${REPOSITORY_PATH}/scripts/technique-files -l -i -f '*.cf' -f '*.st' "${REPOSITORY_PATH}" | while read filename | ||
| do | ||
| if egrep -q "^[^#]*perms\s*=>\s*mog\([^,]+,\s*[^,]+,\s*['\"]root['\"]\)" ${filename}; then | ||
| echo "The file ${filename} attempt to use the 'root' group - use '0' instead for UNIX compatibility" | ||
| exit 11 |
There was a problem hiding this comment.
11 is already used by another test in an upper branch
|
OK, merging |
peckpeck
added a commit
that referenced
this pull request
Jan 12, 2016
…techniques_to_ensure_removed_deprecated_techniques_don_t_come_back_in_an_erroneous_merge Fixes #7504: Add test for rudder-techniques to ensure removed deprecated techniques don't come back in an erroneous merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://www.rudder-project.org/redmine/issues/7504