Fixes #13291: Add a ncf_test scenario to rtf #129
Conversation
Fdall
force-pushed
the
ust_13291/add_a_ncf_test_scenario_to_rtf
branch
from
ff3c235
to
b0c8bdf
Compare
|
Commit modified |
Fdall
force-pushed
the
ust_13291/add_a_ncf_test_scenario_to_rtf
branch
from
b0c8bdf
to
a5c16b8
Compare
|
Commit modified |
Fdall
force-pushed
the
ust_13291/add_a_ncf_test_scenario_to_rtf
branch
from
a5c16b8
to
bb6182f
Compare
|
Commit modified |
Fdall
force-pushed
the
ust_13291/add_a_ncf_test_scenario_to_rtf
branch
from
bb6182f
to
8c7f3f9
Compare
|
Commit modified |
Fdall
force-pushed
the
ust_13291/add_a_ncf_test_scenario_to_rtf
branch
from
8c7f3f9
to
9d3cf00
Compare
|
Commit modified |
| @@ -802,8 +799,10 @@ class Platform: | |||
| rudder_url = host.get_url() | |||
| token = host.run('cat /root/rudder-token') | |||
| if rudder_url is None or token is None: | |||
| print("This platform has no rudder server, can't run this command") | |||
| exit(2) | |||
| rudder_url = '' | |||
There was a problem hiding this comment.
Tests are done on single agent, there are no server deployed.
Fdall
force-pushed
the
ust_13291/add_a_ncf_test_scenario_to_rtf
branch
from
9d3cf00
to
d79b3e6
Compare
|
Commit modified |
|
I also corrected lot of syntax typos. We are still missing a mechanism to destroy the machine if it fails for |
Fdall
force-pushed
the
ust_13291/add_a_ncf_test_scenario_to_rtf
branch
from
d79b3e6
to
c89a803
Compare
|
Commit modified |
| """ Run a scenario on this platform """ | ||
| # test ruby binary |
There was a problem hiding this comment.
Add a try/catch to destroy the vm if an error occured while running the scenario
| process = Popen(command, shell=True, universal_newlines=True) | ||
| else: | ||
| process = Popen(command, stdout=PIPE, shell=True, universal_newlines=True) | ||
| output, error = process.communicate() |
There was a problem hiding this comment.
i think this won't work when you have no pipe at all
There was a problem hiding this comment.
It is working, doc says it returns None if no stdout are scpecified, which is fine here since we want the output to be print to the shell and not captured by python.https://docs.python.org/2/library/subprocess.html#subprocess.Popen.communicate
rtf
Outdated
| return "https://" + adress.group(1) + "/rudder" | ||
| command = "vagrant ssh-config " + self.platform + "_" + aws.group(1) | ||
| process = Popen(command, stdout=PIPE, shell=True, universal_newlines=True) | ||
| output, error = process.communicate() |
There was a problem hiding this comment.
This is a candidate for a call to the shell() function
Fdall
force-pushed
the
ust_13291/add_a_ncf_test_scenario_to_rtf
branch
from
c89a803
to
e33511d
Compare
|
Commit modified |
|
OK, merging this PR |
https://www.rudder-project.org/redmine/issues/13291